Dan Burkert has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4164/4/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: PS4, Line 331: headers I think this would be more accurately worded as "Instantiate template for all physical types." http://gerrit.cloudera.org:8080/#/c/4164/4/src/kudu/common/column_predicate.h File src/kudu/common/column_predicate.h: Line 142: void EvaluateForPhysicalType(const ColumnBlock& block, Can this be private? Line 147: bool EvaluateCell(const void* cell) const { This body can be defined in the cc file. It's only necessary to put the definition in the header if you are not or can not pre-declare all the template specializations. Line 221: // // Templated evaluation will inline the dispatch. left over? -- To view, visit http://gerrit.cloudera.org:8080/4164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccfac9bc899362b442337050795b5ca8c4101268 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
