Todd Lipcon has posted comments on this change.

Change subject: KUDU-1113 pushed predicates not displaying on scans web page
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4206/1/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:

PS1, Line 1488: can report on predicates.
think it would be better to say something like 'report its predicates on the 
/scans page' or something

also, worth noting in this comment that the copy is necessary because 
iter->Init() ends up removing predicates that got pushed down into underlying 
iterators or somesuch


-- 
To view, visit http://gerrit.cloudera.org:8080/4206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21821a1f7b5e4d5e5e1bdec17353ae5f3ef8e408
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to