Todd Lipcon has submitted this change and it was merged. Change subject: Create base class for MiniCluster and ExternalMiniCluster ......................................................................
Create base class for MiniCluster and ExternalMiniCluster This allows utility classes to interoperate with both of these types of clusters. Some minor changes to support this: * Consistent interface for CreateClient() * Consistent interface for Shutdown() Additionally, I removed the 'readability/inheritance' rule from 'make lint' because it prevents using both 'virtual' and 'final' on the same method, however that syntax is required by Clang in C++11 mode. Change-Id: I62256168a9245c845e99f7253f07e69a225954bf Reviewed-on: http://gerrit.cloudera.org:8080/3974 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M build-support/lint.sh M src/kudu/client/client-test.cc M src/kudu/client/predicate-test.cc M src/kudu/client/scan_token-test.cc M src/kudu/integration-tests/all_types-itest.cc M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/client-stress-test.cc M src/kudu/integration-tests/cluster_verifier.cc M src/kudu/integration-tests/create-table-itest.cc M src/kudu/integration-tests/external_mini_cluster-itest-base.h M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/external_mini_cluster.h M src/kudu/integration-tests/flex_partitioning-itest.cc M src/kudu/integration-tests/full_stack-insert-scan-test.cc M src/kudu/integration-tests/linked_list-test.cc M src/kudu/integration-tests/master-stress-test.cc M src/kudu/integration-tests/master_failover-itest.cc M src/kudu/integration-tests/master_migration-itest.cc M src/kudu/integration-tests/master_replication-itest.cc M src/kudu/integration-tests/mini_cluster.cc M src/kudu/integration-tests/mini_cluster.h A src/kudu/integration-tests/mini_cluster_base.h M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/test_workload.cc M src/kudu/integration-tests/test_workload.h M src/kudu/integration-tests/ts_itest-base.h M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/integration-tests/ts_tablet_manager-itest.cc M src/kudu/tserver/ts_tablet_manager-test.cc 29 files changed, 158 insertions(+), 149 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62256168a9245c845e99f7253f07e69a225954bf Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
