Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' ......................................................................
Patch Set 6: Code-Review+1 (3 comments) LGTM, few nits and Qs as usual from my side. http://gerrit.cloudera.org:8080/#/c/4180/5/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: Line 240: "peers", "List of peers where each peer is of form 'uuid:hostname:port'" }) at this point, user may want to know where can he grab this uuid from ? this was the reason i retained 'list_tablets' kinda functionality from fs_list because it means user doesn't have to rely on any other output outside /bin/kudu. well in this case, i think he can grab this uuid from kudu ksck ? http://gerrit.cloudera.org:8080/#/c/4180/6/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: Line 101: return ModeBuilder("table") Come to think of it, I guess these are nothing but operations on the cluster(although table may not span an entire cluster), but I was thinking if it makes sense to keep less number of Modes under bin/kudu and more subModes under cluster. Just some thoughts, we can do this for post 1.0 if we have second thoughts later. http://gerrit.cloudera.org:8080/#/c/4180/5/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: Line 185: .Description("Add a new replica to a tablet's Raft configuration") I am not sure if we want to stay away from using 'Raft config' here, we could just stick to 'add a new replica to tablet'. Nothing wrong in it, but just feels like internal detail. -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
