Adar Dembo has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4180/6/build-support/dist_test.py File build-support/dist_test.py: PS6, Line 80: these. > this Done http://gerrit.cloudera.org:8080/#/c/4180/5/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: Line 240: "peers", "List of peers where each peer is of form 'uuid:hostname:port'" }) > at this point, user may want to know where can he grab this uuid from ? th For the master migration workflow, the user can get it from 'kudu fs dump uuid'. http://gerrit.cloudera.org:8080/#/c/4180/6/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: Line 101: return ModeBuilder("table") > Come to think of it, I guess these are nothing but operations on the cluste Todd (and Dan, I think) requested less nesting of modes where possible. That's ultimately why I made 'table' a top-level mode instead of nesting it under 'cluster'. http://gerrit.cloudera.org:8080/#/c/4180/5/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: Line 185: .Description("Add a new replica to a tablet's Raft configuration") > I am not sure if we want to stay away from using 'Raft config' here, we cou I don't think it matters in this context, as this is an advanced command that very few admins are expected to use. -- To view, visit http://gerrit.cloudera.org:8080/4180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
