Adar Dembo has posted comments on this change.

Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet'

Patch Set 5:

File build-support/

PS6, Line 80: these.
> this
File src/kudu/tools/

Line 240:         "peers", "List of peers where each peer is of form 
'uuid:hostname:port'" })
> at this point, user may want to know where can he grab this uuid from ?  th
For the master migration workflow, the user can get it from 'kudu fs dump uuid'.
File src/kudu/tools/

Line 101:   return ModeBuilder("table")
> Come to think of it, I guess these are nothing but operations on the cluste
Todd (and Dan, I think) requested less nesting of modes where possible. That's 
ultimately why I made 'table' a top-level mode instead of nesting it under 
File src/kudu/tools/

Line 185:       .Description("Add a new replica to a tablet's Raft 
> I am not sure if we want to stay away from using 'Raft config' here, we cou
I don't think it matters in this context, as this is an advanced command that 
very few admins are expected to use.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e96fc5b0106946f29a2faee8e2667be738b740
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <>
Gerrit-Reviewer: Adar Dembo <>
Gerrit-Reviewer: Alexey Serbin <>
Gerrit-Reviewer: Dinesh Bhat <>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <>
Gerrit-Reviewer: Todd Lipcon <>
Gerrit-HasComments: Yes

Reply via email to