Todd Lipcon has posted comments on this change. Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4417/4/python/kudu/util.py File python/kudu/util.py: Line 43: If a string is provided, a format must be provided as well. should clarify the timezone handling. If I wrote "14:34:05" does that mean in local time or UTC? I'm guessing UTC, but should specify (and test) Line 64: Convert the input unixtime_micros value to a datetime. what's the range of Python datetime? Is this always possible? Also, are you creating a tz-aware datetime? https://docs.python.org/2/library/datetime.html seems to indicate there are lot of variants here and this stuff's tricky. -- To view, visit http://gerrit.cloudera.org:8080/4417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
