Adar Dembo has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' ......................................................................
Patch Set 2: (2 comments) Would be nice to get a little coverage of the new path, especially since there was that bug in the first patch which didn't list all the tables. Could you add something to TestListTables in kudu-admin-test? We should test listing of multiple tables, and verify the new output if possible. http://gerrit.cloudera.org:8080/#/c/4440/2/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: Line 641: .AddOptionalParameter("dump_data") Nit: maintain alphabetical order. http://gerrit.cloudera.org:8080/#/c/4440/2/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: PS2, Line 34: "Print list of tablets for the table along with replica uuids" Nit: how about "Include tablet and replica UUIDs in the output"? -- To view, visit http://gerrit.cloudera.org:8080/4440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f8e0dfb8e7ba9f67d5926199a9b831351585a7 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes