Dinesh Bhat has posted comments on this change.
Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'
Patch Set 2:
> (2 comments)
> Would be nice to get a little coverage of the new path, especially
> since there was that bug in the first patch which didn't list all
> the tables. Could you add something to TestListTables in
> kudu-admin-test? We should test listing of multiple tables, and
> verify the new output if possible.
Thanks, yeah that alarmed a test for sure. I will upload a new patch with test.
Also on an ortho topic of making the output to machine-readable by keeping
loglevels to only WARNING and above: I realized couple of ways to do that is to
use big hammer FLAG_minloglevel = 2 or
google::SetCommandLineOption(minloglevel, 2) from code , but that also means we
are losing the access to all logs below WARNING. Does that mean it's a no-go ?
Come to think of it, any script wants to consume this output, it could use
'kudu ... 2>/dev/null' which isn't a bad assumption.
Line 641: .AddOptionalParameter("dump_data")
> Nit: maintain alphabetical order.
PS2, Line 34: "Print list of tablets for the table along with replica uuids"
> Nit: how about "Include tablet and replica UUIDs in the output"?
To view, visit http://gerrit.cloudera.org:8080/4440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Owner: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins