Dinesh Bhat has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' ......................................................................
Patch Set 2: (2 comments) > (2 comments) > > Would be nice to get a little coverage of the new path, especially > since there was that bug in the first patch which didn't list all > the tables. Could you add something to TestListTables in > kudu-admin-test? We should test listing of multiple tables, and > verify the new output if possible. Thanks, yeah that alarmed a test for sure. I will upload a new patch with test. Also on an ortho topic of making the output to machine-readable by keeping loglevels to only WARNING and above: I realized couple of ways to do that is to use big hammer FLAG_minloglevel = 2 or google::SetCommandLineOption(minloglevel, 2) from code , but that also means we are losing the access to all logs below WARNING. Does that mean it's a no-go ? Come to think of it, any script wants to consume this output, it could use 'kudu ... 2>/dev/null' which isn't a bad assumption. http://gerrit.cloudera.org:8080/#/c/4440/2/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: Line 641: .AddOptionalParameter("dump_data") > Nit: maintain alphabetical order. Done http://gerrit.cloudera.org:8080/#/c/4440/2/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: PS2, Line 34: "Print list of tablets for the table along with replica uuids" > Nit: how about "Include tablet and replica UUIDs in the output"? Done -- To view, visit http://gerrit.cloudera.org:8080/4440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f8e0dfb8e7ba9f67d5926199a9b831351585a7 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
