Dan Burkert has posted comments on this change. Change subject: thirdparty: split into dependency groups ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4513/1//COMMIT_MSG Commit Message: Line 29: "instrumented_msan" dependency group). Will this actually work for msan, though? My understanding is that msan requires _all_ dependencies to be instrumented, which would result in a "dependency group" all on it's own, with no dependency on the common group. Maybe that's fine? http://gerrit.cloudera.org:8080/#/c/4513/1/thirdparty/build-if-necessary.sh File thirdparty/build-if-necessary.sh: PS1, Line 86: # leftover http://gerrit.cloudera.org:8080/#/c/4513/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: Line 363: build_protobuf hmm. I think what this is saying, is that protobuf (and the others below) get built in tsan mode, whenever you call build-thirdparty.sh protobuf. Thats great in theory (I think you asked me the other day and I said I supported that), but it seems to me that if you start off with a clean thirdparty and call 'build-thirdparty.sh protobuf' it's going to try and build an instrumented protobuf without having built an instrumented libc++ to link it against. -- To view, visit http://gerrit.cloudera.org:8080/4513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I549262858f98b5ce6c78e786e8c8d8134ba2ed36 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
