Alexey Serbin has posted comments on this change. Change subject: [c++client/samples] added README for the sample ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4517/1/src/kudu/client/samples/README.adoc File src/kudu/client/samples/README.adoc: Line 23: * Make sure `cmake` of version at least 2.6.2 is installed on the system. > does the sample require this new of a cmake? in the past we actually built Requiring cmake of 2.6.2 might be too lose here: it's a typo and the CMakeLists.txt itself declares mininum 2.8 :) Will fix, thanks. PS1, Line 31: /tmp/client_alt_root` > doesn't seem to match what's used below oops, this is due to too many revisions :) Will fix. PS1, Line 37: Change the d > Change into the directory? cd into? Done Line 47: cmake -G "Unix Makefiles" -DkuduClient_DIR=/usr/local/share/kuduClient/cmake -DCMAKE_BUILD_TYPE=release > the 'unix makefiles' is the default. yep, that's the default. Probably, I added it here because I ran it with Xcode and Ninja. Will remove. Without kuduClient_DIR it did not work for me if installing into alternative destroot. I just copied it over here as well. Will test and update for the default install root. -- To view, visit http://gerrit.cloudera.org:8080/4517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
