Dan Burkert has posted comments on this change.

Change subject: thirdparty: reorganize tree
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4550/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

Line 1: #!/bin/bash
Is this necessary?


Line 43: restore_env() {
Should this now include MODE_SUFFIX?  I think that might be good so that we 
will fail fast if we try to use it without setting it.

Although now that I'm looking, I don't think we set -u, so it may not make a 
difference.


Line 439:   rsync -a $BOOST_SOURCE/boost $PREFIX/include
Not your change, but this rsync incantation is using different flags than the 
others, is that intentional?


-- 
To view, visit http://gerrit.cloudera.org:8080/4550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06aa75ab5e81f2563986244950e9dcda06c2d383
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to