Adar Dembo has posted comments on this change. Change subject: thirdparty: reorganize tree ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4550/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 1: #!/bin/bash > Is this necessary? Every other shell script in the Kudu repo uses it, so I figure it's best to be consistent. Plus, I might be introducing bash-isms with these changes, so better safe than sorry. Line 43: restore_env() { > Should this now include MODE_SUFFIX? I think that might be good so that we Ahh, didn't realize PREFIX was also saved/restored. Yeah, I'll add MODE_SUFFIX too. Line 439: rsync -a $BOOST_SOURCE/boost $PREFIX/include > Not your change, but this rsync incantation is using different flags than t You referring to the lack of -v, or --delete? The former is because boost tree is stupendously huge, so logging every file (-v) is kind of a drag. But --delete should probably go in there, otherwise we may not notice header removals during upgrades. I'll add it. -- To view, visit http://gerrit.cloudera.org:8080/4550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06aa75ab5e81f2563986244950e9dcda06c2d383 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
