Adar Dembo has posted comments on this change. Change subject: Clean up switch statements in column_predicate.cc ......................................................................
Patch Set 1: Code-Review+2 OK, though I think Dinesh had added default switch statements to remove some "return without value" (or whatever) warnings in this code. Can those still be addressed? -- To view, visit http://gerrit.cloudera.org:8080/4599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80b750f7bc7455607c380ca65744d8cc66eeabd1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
