Dan Burkert has posted comments on this change. Change subject: Clean up switch statements in column_predicate.cc ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4599/1/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: Line 592: LOG(FATAL) << "unknown predicate type"; > Please confirm that this doesn't return a warning about not returning a boo It doesn't; we use this pattern in multiple places already in this file and elsewhere. -- To view, visit http://gerrit.cloudera.org:8080/4599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80b750f7bc7455607c380ca65744d8cc66eeabd1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
