Dan Burkert has submitted this change and it was merged. Change subject: Clean up switch statements in column_predicate.cc ......................................................................
Clean up switch statements in column_predicate.cc Where possible, remove default branches in favor of LOG(FATAL) calls outside the switch. This makes it more likely that the switch will be updated in the future for new predicate types, since C++ compilers can warn on incomplete switches if there is no default branch. Also cleans up a confusing fall-through in ColumnPredicate::operator==. Change-Id: I80b750f7bc7455607c380ca65744d8cc66eeabd1 Reviewed-on: http://gerrit.cloudera.org:8080/4599 Reviewed-by: Adar Dembo <[email protected]> Reviewed-by: Todd Lipcon <[email protected]> Reviewed-by: Dinesh Bhat <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/common/column_predicate.cc 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Dinesh Bhat: Looks good to me, but someone else must approve Adar Dembo: Looks good to me, approved Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80b750f7bc7455607c380ca65744d8cc66eeabd1 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
