Adar Dembo has posted comments on this change. Change subject: [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4570/1//COMMIT_MSG Commit Message: PS1, Line 19: 101 > Not having this limit would be hurtful in production, it means runaway oper I don't like how the limit may trigger accidentally if the cluster is under heavy load and the user has asked for long timeouts. I also don't like that it violates the (otherwise universally applied) contract that timeouts reign supreme. And for what it's worth, we've had a tight loop or two in the C++ client before and we've managed to find them without such a limit, which is partly why no such thing exists there. Since it appears that we agree to disagree, I'll ask around for a third opinion. -- To view, visit http://gerrit.cloudera.org:8080/4570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2bd53b03551642e4d036d322e1e592b7c2cfec Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
