Hello David Ribeiro Alves, Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4620
to review the following change.
Change subject: raft_consensus: clean up overrides, protected methods
......................................................................
raft_consensus: clean up overrides, protected methods
RaftConsensus used to have a subclass mock in raft_consensus-test, but
that test is now removed. Given this, we can make some
previously-protected methods private and non-virtual.
I also took this opportunity to modernize the 'override' style to C++11,
and also to remove a function which was essentially duplicate code.
Change-Id: Ib52d3ac40ed68a4ff8b1738897f6ef62f94a843b
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
3 files changed, 45 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/4620/1
--
To view, visit http://gerrit.cloudera.org:8080/4620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib52d3ac40ed68a4ff8b1738897f6ef62f94a843b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
