Todd Lipcon has submitted this change and it was merged. Change subject: raft_consensus: clean up overrides, protected methods ......................................................................
raft_consensus: clean up overrides, protected methods RaftConsensus used to have a subclass mock in raft_consensus-test, but that test is now removed. Given this, we can make some previously-protected methods private and non-virtual. I also took this opportunity to modernize the 'override' style to C++11, and also to remove a function which was essentially duplicate code. Change-Id: Ib52d3ac40ed68a4ff8b1738897f6ef62f94a843b Reviewed-on: http://gerrit.cloudera.org:8080/4620 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h M src/kudu/consensus/raft_consensus_quorum-test.cc 3 files changed, 45 insertions(+), 64 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib52d3ac40ed68a4ff8b1738897f6ef62f94a843b Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
