Todd Lipcon has posted comments on this change. Change subject: consensus: refactor tracking of received OpIds out of ReplicaState ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4476/2/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 565: // TODO(todd) count of number of ops failed due to consensus queue overflow. > side note: these warnings are helpful but problematic, newcomers to a code There was a mailing list thread about this a couple weeks ago and people seemed to be in favor of keeping them. My policy is just to use git blame to figure out who wrote the TODO and put their name there :) -- To view, visit http://gerrit.cloudera.org:8080/4476 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81614d26328b0fbba37bf279f59717e05a07b816 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
