Todd Lipcon has posted comments on this change. Change subject: KUDU-1684 - [python] Add Scan Resource Metrics Capabilities ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4675/1/python/kudu/client.pyx File python/kudu/client.pyx: Line 2128: const ResourceMetrics* _metrics this is dangerous, since you aren't holding onto the Scanner object, and the ResourceMetrics are only live as long as the Scanner is. I think you either need to somehow reference the Scanner, or should extract all the values at construction time. Otherwise it's very easy for a user to accidentally write a use-after-free PS1, Line 2137: count would say metric value, since not all metrics are necessarily counts -- To view, visit http://gerrit.cloudera.org:8080/4675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6c4057bd2644e46bdbf8bae0d4a768306e2dbd9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes