David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-1365. Add leader pre-elections ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4694/2/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1908: StartElection(NORMAL_ELECTION, reason); > Yea, that looks possible, but I don't think it causes problems except for a Just afraid that this interleaving will not be so unlikely with pre-elections. Since they require no IO, aren't they likely to go faster than regular elections? Maybe I'm missing a serialization point somewhere though. Well we can always do nothing and see if this manifests itself in real scenarios. One thing we might consider if this becomes pathological (and I haven't fully thought this through), is to only do pre-elections when there isn't a real election going on. Since pre-elections are mostly for the sake of the partitioned/slow node that now can make sure that an election is called for when it comes back, pre-elections would still be helpful here, wheres if there just an election race where multiple replicas are trying to elect themselves pre-elections aren't helpful (maybe even worse?). -- To view, visit http://gerrit.cloudera.org:8080/4694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcfabd8c9ffe31f17ab768542a046426f656db43 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
