Hello David Ribeiro Alves, Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4704
to review the following change.
Change subject: consensus_peers: a little cleanup of cruft
......................................................................
consensus_peers: a little cleanup of cruft
* removes a test method that no longer was necessary
* removes an unimplemented method
* cleans up comments
* makes PeerManager methods non-virtual now that we no longer try to
mock them
In particular I removed a big "state diagram" that I didn't find very
helpful and replaced it with a bit more text.
This is in prep for some work on KUDU-699.
Change-Id: Ie01c24b840e456482c12f96f3e2bcb3ad4388f0b
---
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/peer_manager.h
4 files changed, 22 insertions(+), 66 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/4704/1
--
To view, visit http://gerrit.cloudera.org:8080/4704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie01c24b840e456482c12f96f3e2bcb3ad4388f0b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
