Todd Lipcon has submitted this change and it was merged. Change subject: consensus_peers: a little cleanup of cruft ......................................................................
consensus_peers: a little cleanup of cruft * removes a test method that no longer was necessary * removes an unimplemented method * cleans up comments * makes PeerManager methods non-virtual now that we no longer try to mock them In particular I removed a big "state diagram" that I didn't find very helpful and replaced it with a bit more text. This is in prep for some work on KUDU-699. Change-Id: Ie01c24b840e456482c12f96f3e2bcb3ad4388f0b Reviewed-on: http://gerrit.cloudera.org:8080/4704 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/consensus/consensus_peers-test.cc M src/kudu/consensus/consensus_peers.cc M src/kudu/consensus/consensus_peers.h M src/kudu/consensus/peer_manager.h 4 files changed, 23 insertions(+), 67 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie01c24b840e456482c12f96f3e2bcb3ad4388f0b Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>