Dan Burkert has posted comments on this change. Change subject: [java client] Cleanup AsyncKuduClient's unused caches ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4705/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 178: final HashMap<String, TabletClient> ip2client = new HashMap<>(); Could you add a "GuardedBy" annotation to this? Line 2008: void addTabletClient(String uuid, String host, int port, boolean isLeader) If this has to be called with tabletServers synchronized, then it should be private, since tabletServers is private. Also, remove the comment and add a GuardedBy annotation. -- To view, visit http://gerrit.cloudera.org:8080/4705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62802c34c618c83a4ff69d79825387cbe4ab51a8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
