Adar Dembo has posted comments on this change. Change subject: [java client] Cleanup AsyncKuduClient's unused caches ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4705/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: PS2, Line 144: /** : * This map contains data cached from calls to the master's : * GetTableLocations RPC. : * : * This map is keyed by table ID. : */ Nit: just combine the two paragraphs, like "This map contains data cached from calls to the master's GetTableLocations RPC. It is keyed by table ID." Line 1360: // Early creating the tablet so that it parses out the pb. This comment is probably unnecessary now. -- To view, visit http://gerrit.cloudera.org:8080/4705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62802c34c618c83a4ff69d79825387cbe4ab51a8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
