Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Cleanup AsyncKuduClient's unused caches ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4705/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: PS2, Line 144: /** : * This map contains data cached from calls to the master's : * GetTableLocations RPC. This map is keyed by table ID. : */ : private final ConcurrentHashMap<String, TableLocationsCache> tableLocations = : > Nit: just combine the two paragraphs, like "This map contains data cached f Done Line 178: > Could you add a "GuardedBy" annotation to this? Done Line 1360: Slice tabletId = rt.tabletId; > This comment is probably unnecessary now. Done Line 2008: String ip = getIP(host); > If this has to be called with tabletServers synchronized, then it should be Done -- To view, visit http://gerrit.cloudera.org:8080/4705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62802c34c618c83a4ff69d79825387cbe4ab51a8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
