David Ribeiro Alves has posted comments on this change. Change subject: consensus: move more logic from ReplicaState to RaftConsensus ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4709/1/src/kudu/consensus/consensus_queue.h File src/kudu/consensus/consensus_queue.h: PS1, Line 257: bool IsCommittedIndexInCurrentTerm() const; Is there an opportunity for the caller and the queue to disagree on what is the "current" term? http://gerrit.cloudera.org:8080/#/c/4709/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 618: DCHECK(round->replicate_msg()->change_config_record().has_old_config()); are these DCHECKs really necessary? old/new config are required fields of ChangeConfigRecordPB. We could likely replace this with just a DCHECK that the old/new config have the op id set below. -- To view, visit http://gerrit.cloudera.org:8080/4709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f377ebb132f3f58f984605197831f41198d78c5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
