Mike Percy has posted comments on this change. Change subject: consensus: move more logic from ReplicaState to RaftConsensus ......................................................................
Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4709/3/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 2063: // NOTE: the ReplicaState lock is held here because this is triggered by Thanks for this comment. I think it would also be helpful to mention this in the header file for ConsensusRound::NotifyReplicationFinished() and maybe also RaftConsensus::NonTxRoundReplicationFinished() -- To view, visit http://gerrit.cloudera.org:8080/4709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f377ebb132f3f58f984605197831f41198d78c5 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
