David Ribeiro Alves has posted comments on this change.

Change subject: consensus: move more logic from ReplicaState to RaftConsensus
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4709/3/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:

PS3, Line 405: Handle
this wording is confusing. does this mean that it was replicated or committed? 
can you make the distinction in the name/commments?


PS3, Line 427: but first check for
             :   // and handle any consensus-related operations
what operations does this refer to? what is this "handling"?


http://gerrit.cloudera.org:8080/#/c/4709/3/src/kudu/consensus/raft_consensus_state.cc
File src/kudu/consensus/raft_consensus_state.cc:

Line 510: 
extra line


-- 
To view, visit http://gerrit.cloudera.org:8080/4709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f377ebb132f3f58f984605197831f41198d78c5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to