Alexey Serbin has posted comments on this change. Change subject: [client.h] updated comment for CountBufferedOperations ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4723/1/src/kudu/client/client.h File src/kudu/client/client.h: PS1, Line 1488: > nit: extra blank space. Done PS1, Line 1493: This is different than HasPendingOperations() above > It makes you wonder if we want this method at all. On the Java side there's Yep -- so far I can see, this method is used only in tests. However, MJ for some reason was interested in this method as well. Changing the name or dropping this method are both incompatible changes from the point of API compatibility. If making such a change, I would vote for dropping this method (or at least declaring it as duplicate) if we are not sure whether it's useful at all. Do you think we want to make such a change in 1.1.x? -- To view, visit http://gerrit.cloudera.org:8080/4723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6293c0a3058f7056d24e7cee0120d1852ded548 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
