Alexey Serbin has posted comments on this change. Change subject: [client.h] updated comment for CountBufferedOperations ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4723/1/src/kudu/client/client.h File src/kudu/client/client.h: PS1, Line 1493: This is different than HasPendingOperations() above > Yes, I ultimately decided I will not end up using this, but thanks for clar ok, I see. Thank you for the clarification, MJ! PS1, Line 1493: This is different than HasPendingOperations() above > Well that MJ was interested is... interesting since Impala will be using AU OK, it seems now it's clear that this method is not needed since in MANUAL_FLUSH mode it's possible just to count how many times Apply() was called since the last Flush() or last notification via callback of FlushAsync(). In all other flush modes, this method does not provide useful information. Basically, let's remove it from the public interface and use only for in our tests. But for now, let's start from marking it as an obsolete. -- To view, visit http://gerrit.cloudera.org:8080/4723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6293c0a3058f7056d24e7cee0120d1852ded548 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
