Matthew Jacobs has posted comments on this change.

Change subject: [client.h] updated comment for CountBufferedOperations
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4723/1/src/kudu/client/client.h
File src/kudu/client/client.h:

PS1, Line 1493: This is different than HasPendingOperations() above
> Well that MJ was interested is... interesting since Impala will be using AU
Yes, I ultimately decided I will not end up using this, but thanks for 
clarifying the message. I can't imagine this being useful w/ 
AUTO_FLUSH_BACKGROUND given the semantics.

BTW, the reason I was interested in this is for us to keep track of the number 
of writes that actually went through. The idea was to compute:

total_num_rows_we_added - pending_in_buffer - total_num_errors

I'm just going to compute this at the end and then we don't worry about pending 
in buffer.


-- 
To view, visit http://gerrit.cloudera.org:8080/4723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6293c0a3058f7056d24e7cee0120d1852ded548
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to