Todd Lipcon has posted comments on this change. Change subject: consensus: split ReplicaState in twain[1] ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4713/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 657: } > warning: missing username/bug in TODO [google-readability-todo] removed this TODO, I think it's right. http://gerrit.cloudera.org:8080/#/c/4713/1/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: Line 454: // TODO(mpercy): Plumb this from ServerBase. > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/4713/3/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: Line 450: PendingRounds pending_; > Add comment indicating how this is protected? Done -- To view, visit http://gerrit.cloudera.org:8080/4713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95308ae8a5d65ada016ae08e0e8cf06c54b35909 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
