Todd Lipcon has posted comments on this change. Change subject: rpc: support GSSAPI authentication ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4763/2//COMMIT_MSG Commit Message: PS2, Line 36: If we don't want to inherit the direct dependency on the krb5 : headers, we could remove this test. > We could also do regex matches against the output of klist. yea but that works regardless of whether we've set our own process's environment properly for SASL/GSSAPI to pick up the creds http://gerrit.cloudera.org:8080/#/c/4763/2/src/kudu/rpc/sasl_rpc-test.cc File src/kudu/rpc/sasl_rpc-test.cc: Line 68: SocketCallable server_runner) { > warning: the parameter 'server_runner' is copied for each invocation but on Done PS2, Line 168: server > client Done Line 185: // Create the server principal and keytab. > Does the first test do something different if the server doesn't have a key hrm, so you mean a test with no creds on the client _or_ on the server? sure, can add that http://gerrit.cloudera.org:8080/#/c/4763/2/src/kudu/rpc/sasl_server.cc File src/kudu/rpc/sasl_server.cc: PS2, Line 213: NULL > nullptr Done -- To view, visit http://gerrit.cloudera.org:8080/4763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1b93045acd428ef3437597059c5106b03e25d0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
