Todd Lipcon has posted comments on this change. Change subject: rpc: support GSSAPI authentication ......................................................................
Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/4763/3/src/kudu/rpc/sasl_helper.cc File src/kudu/rpc/sasl_helper.cc: PS3, Line 50: plain_enabled_(false), : gssapi_enabled_(false) > Aren't they mutually exclusive? Nope -- on the client I think the default is probably "try to do secure, and if that fails because the server isn't secure, fall back to insecure" (with the option for a client to enforce security) http://gerrit.cloudera.org:8080/#/c/4763/3/src/kudu/rpc/sasl_rpc-test.cc File src/kudu/rpc/sasl_rpc-test.cc: Line 26: #include <stdlib.h> > nit: by google style guide, this should come before c++ standard headers (o Done PS3, Line 64: std::function > Does it need #include <functional> ? Done http://gerrit.cloudera.org:8080/#/c/4763/3/src/kudu/security/mini_kdc-test.cc File src/kudu/security/mini_kdc-test.cc: Line 62: CHECK_EQ(0, krb5_cc_default(ctx, &ccache)); > Trying to remember, did we just decide to remove this? I think so but want looked back in the history and it seems that was the decision. removed it. http://gerrit.cloudera.org:8080/#/c/4763/3/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: Line 25: #include <stdlib.h> > nit: please either convert into <cstdlib> or move up before C++ headers set Done PS3, Line 328: Status MiniKdc::SetKrb5Environment() > const specifier? Done Line 333: CHECK_ERR(setenv(p.first.c_str(), p.second.c_str(), 1 /*overrwrite*/)); > oops, typo in this line. Done http://gerrit.cloudera.org:8080/#/c/4763/3/src/kudu/security/mini_kdc.h File src/kudu/security/mini_kdc.h: Line 82: Status CreateServiceKeytab(const std::string& spn, std::string* path); > Please cover this in mini_kdc-test Done -- To view, visit http://gerrit.cloudera.org:8080/4763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1b93045acd428ef3437597059c5106b03e25d0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
