Dan Burkert has posted comments on this change. Change subject: KuduRPC integration with OpenSSL ......................................................................
Patch Set 1: (13 comments) This is great. Did a quick first pass mostly looking at style, I'll take a harder look at the openssl usage soon. http://gerrit.cloudera.org:8080/#/c/4789/1/CMakeLists.txt File CMakeLists.txt: PS1, Line 836: STATIC_LIB I think we want SHARED_LIB here, so we aren't statically linking. http://gerrit.cloudera.org:8080/#/c/4789/1/cmake_modules/FindOpenSSL.cmake File cmake_modules/FindOpenSSL.cmake: Line 25: set(_OPENSSL_SEARCH_DIR) Is there a reason not use the built in FindOpenSSL in Cmake? http://gerrit.cloudera.org:8080/#/c/4789/1/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: PS1, Line 71: NULL prefer using nullptr here and below. http://gerrit.cloudera.org:8080/#/c/4789/1/src/kudu/rpc/connection.h File src/kudu/rpc/connection.h: PS1, Line 144: Socket *socket() Keep the asterisk with the type: Socket* socket() http://gerrit.cloudera.org:8080/#/c/4789/1/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: Line 60: DEFINE_string(ssl_server_certificate, "", "Path to the SSL certificate to be used."); Mark these experimental, for example: TAG_FLAG(ssl_server_certificate, experimental); http://gerrit.cloudera.org:8080/#/c/4789/1/src/kudu/rpc/messenger.h File src/kudu/rpc/messenger.h: Line 188: bool ssl_enabled() { return ssl_enabled_; } const PS1, Line 189: whitespace http://gerrit.cloudera.org:8080/#/c/4789/1/src/kudu/rpc/rpc-test-base.h File src/kudu/rpc/rpc-test-base.h: Line 345: int n_reactors = 1, bool enable_ssl = false) { Put the new arg on it's own line, and please fix up the indent while you are at it. http://gerrit.cloudera.org:8080/#/c/4789/1/src/kudu/rpc/sasl_rpc-test.cc File src/kudu/rpc/sasl_rpc-test.cc: PS1, Line 53: NULL prefer nullptr here and below http://gerrit.cloudera.org:8080/#/c/4789/1/src/kudu/rpc/sasl_server.h File src/kudu/rpc/sasl_server.h: Line 48: // Does not take ownership of the socket indicated by the fd. Update this comment. PS1, Line 69: whitespace http://gerrit.cloudera.org:8080/#/c/4789/1/src/kudu/util/net/ssl_factory.cc File src/kudu/util/net/ssl_factory.cc: Line 42: return pthread_self(); This likely won't work on OS X. Use UniqueThreadId() in thread.h instead. PS1, Line 69: NULL nullptr here and elsewhere. -- To view, visit http://gerrit.cloudera.org:8080/4789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27167faa4e6a78e59b46093055b16682c93af0ea Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
