Alexey Serbin has posted comments on this change. Change subject: KuduRPC integration with OpenSSL ......................................................................
Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/4789/2/CMakeLists.txt File CMakeLists.txt: PS2, Line 834: include_directories(${OPENSSL_INCLUDE_DIR}) Why not to add this only when it's relevant? I.e. in util CMakeFiles.txt PS2, Line 835: ADD_THIRDPARTY_LIB(openssl_ssl : STATIC_LIB "${OPENSSL_SSL}") : ADD_THIRDPARTY_LIB(openssl_crypto : STATIC_LIB "${OPENSSL_CRYPTO}") Most likely, we don't want this to be third-party, we will use system libraries. http://gerrit.cloudera.org:8080/#/c/4789/2/cmake_modules/FindOpenSSL.cmake File cmake_modules/FindOpenSSL.cmake: Why is it needed? Aren't that installed/share/cmake-3.6/Modules/FindOpenSSL.cmake is not enough? Most probably, we will use system crypto and ssl libraries, linking with them dynamically. http://gerrit.cloudera.org:8080/#/c/4789/2/src/kudu/rpc/connection.h File src/kudu/rpc/connection.h: PS2, Line 232: gscoped_ptr Consider using std::unique_ptr instead. http://gerrit.cloudera.org:8080/#/c/4789/2/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: PS2, Line 205: openssl_crypto ${OPENSSL_CRYPTO_LIBRARY} PS2, Line 206: openssl_ssl ${OPENSSL_SSL_LIBRARY} http://gerrit.cloudera.org:8080/#/c/4789/2/src/kudu/util/net/ssl_factory.cc File src/kudu/util/net/ssl_factory.cc: PS2, Line 92: NetworkError To me this does not look like a network error: it's close either to NotFound, Corrupted, or RunTimeError. http://gerrit.cloudera.org:8080/#/c/4789/2/src/kudu/util/net/ssl_factory.h File src/kudu/util/net/ssl_factory.h: PS2, Line 60: SSL_CTX Consider using unique_ptr with custom deleter. -- To view, visit http://gerrit.cloudera.org:8080/4789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27167faa4e6a78e59b46093055b16682c93af0ea Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
