Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL ......................................................................
Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4789/3/src/kudu/rpc/reactor.cc File src/kudu/rpc/reactor.cc: Line 51: #include "kudu/util/status.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/4789/3/src/kudu/rpc/rpc-test-base.h File src/kudu/rpc/rpc-test-base.h: Line 321: Status CreateSSLServerCert(std::string file_path) { > warning: the parameter 'file_path' is copied for each invocation but only u Done Line 355: Status CreateSSLPrivateKey(std::string file_path) { > warning: the parameter 'file_path' is copied for each invocation but only u Done http://gerrit.cloudera.org:8080/#/c/4789/3/src/kudu/util/net/socket.h File src/kudu/util/net/socket.h: Line 125: Status BlockingWrite(const uint8_t *buf, size_t buflen, size_t *num_written, > warning: function 'kudu::Socket::BlockingWrite' has a definition with diffe Done http://gerrit.cloudera.org:8080/#/c/4789/3/src/kudu/util/net/ssl_factory.cc File src/kudu/util/net/ssl_factory.cc: Line 78: if (ctx_.get() == nullptr) { > warning: redundant get() call on smart pointer [google-readability-redundan Done http://gerrit.cloudera.org:8080/#/c/4789/3/src/kudu/util/net/ssl_socket.cc File src/kudu/util/net/ssl_socket.cc: Line 62: bool VerifyHost(const std::string& hostname, const std::string& subject_name, int size) { > warning: parameter 'size' is unused [misc-unused-parameters] Done -- To view, visit http://gerrit.cloudera.org:8080/4789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27167faa4e6a78e59b46093055b16682c93af0ea Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
