Alexey Serbin has posted comments on this change. Change subject: WIP [java client] Implement RPC tracing ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4781/1/java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceObject.java File java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceObject.java: PS1, Line 33: private final TabletClient server Is it possible to store just the identifier here? My concern is that a trace object could accumulate too many dead references (i.e. references which are not used for anything else but just being stored here for reporting purposes). So far I do not see any other usage of this object as a member of RpcTraceObject class besides call of the getUuid() method. http://gerrit.cloudera.org:8080/#/c/4781/1/java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java: PS1, Line 225: sendRpc(rpc); Is it necessary to add a trace here as well? -- To view, visit http://gerrit.cloudera.org:8080/4781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69ef56acc071b9f80b34e38c1821df4096f54907 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
