Jean-Daniel Cryans has posted comments on this change. Change subject: WIP [java client] Implement RPC tracing ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4781/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java: Line 233: * only one related RPC. > worth documenting that you should be careful not to cause any cycle in "rel Good idea, I wasn't super happy with "related" but when we talked about a while ago that's the name we came up with. "parent" in this implementation makes more sense. http://gerrit.cloudera.org:8080/#/c/4781/1/java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceObject.java File java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceObject.java: PS1, Line 33: private final TabletClient server > Is it possible to store just the identifier here? My concern is that a tra I think we'll want to print more information, but it just so happens that I have this other patch https://gerrit.cloudera.org/#/c/4836/ that adds a new class that we could use here instead :) http://gerrit.cloudera.org:8080/#/c/4781/1/java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java: PS1, Line 225: sendRpc(rpc); > Is it necessary to add a trace here as well? No, you'd get double-logging since you'd add it here then again on line 162. -- To view, visit http://gerrit.cloudera.org:8080/4781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69ef56acc071b9f80b34e38c1821df4096f54907 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
