Jean-Daniel Cryans has posted comments on this change. Change subject: WIP [java client] Implement RPC tracing ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4781/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: PS2, Line 975: relatedRpc > nit: does it makes sense to rename the parameter as well: relatedRpc --> pa Yup, already did that for the next revision. http://gerrit.cloudera.org:8080/#/c/4781/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java: PS2, Line 238: this.parentRpc = parentRpc > Nit: does it make sense to protect against setting parentRpc to itself? Lemme add an assert. http://gerrit.cloudera.org:8080/#/c/4781/2/java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java: PS2, Line 568: return an exception if we couldn't dispatch the error, or null > nit: probably, this out of the scope, but just in case: do we use @return t This is just Javadoc standards, here I use @return because it's what this method returns. You'd use @throws if it was thrown. -- To view, visit http://gerrit.cloudera.org:8080/4781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69ef56acc071b9f80b34e38c1821df4096f54907 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
