Dan Burkert has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4836/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 1295: throw new NonRecoverableException(statusIOE); There's a new codepath where 'servers' might be empty. I think this should throw as well. It would be great if the null return and UHE codepaths code be merged/simplified. Right now connectTS has two ways to return errors. http://gerrit.cloudera.org:8080/#/c/4836/1/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java File java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java: Line 95: * @return an object that contains all the server's information doc the null return http://gerrit.cloudera.org:8080/#/c/4836/2/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: PS2, Line 38: once it is init()'d please update Line 163: return lastUuid; http://dilbert.com/strip/2001-10-25 http://gerrit.cloudera.org:8080/#/c/4836/2/java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java File java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java: Line 26: @InterfaceStability.Evolving Is this needed for Private interfaces? -- To view, visit http://gerrit.cloudera.org:8080/4836 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33984a437d8c8d07d5db4d16f8da723b3e904189 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-HasComments: Yes
