Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4836/2/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: PS2, Line 38: once it is init()'d > please update Done PS2, Line 151: or null if this : * cache doesn't know of any servers > Is this actually possible? Wouldn't we reject the creation of a RemoteTable Super stale cache and all the replicas moved and we, for some reason, don't query the master each time we find a tablet has moved. Almost impossible. Line 163: return lastUuid; > http://dilbert.com/strip/2001-10-25 Hey that's how this patch failed the first time, values() returned things in a different order on my machine and on Linux. http://gerrit.cloudera.org:8080/#/c/4836/2/java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java File java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java: Line 26: @InterfaceStability.Evolving > Is this needed for Private interfaces? Not really, I'll remove. -- To view, visit http://gerrit.cloudera.org:8080/4836 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33984a437d8c8d07d5db4d16f8da723b3e904189 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-HasComments: Yes
