Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4836/3/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: PS3, Line 149: a random server UUID : * will be returned > xs nit: avoid the passive voice. e.g. "If none is closer than the others, r Done http://gerrit.cloudera.org:8080/#/c/4836/3/java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java File java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java: PS3, Line 33: UUID > s/UUID/server There might be more than one master/tserver running on a server so I'm trying to make a distinction here. http://gerrit.cloudera.org:8080/#/c/4836/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java: PS3, Line 100: care > care about? Done PS3, Line 101: assertNotNull(tablet.getClosestUUID()); > is this one not local? could we add an assertion? Above we purposefully indicated that there would be no local replicas built, so testing this is like testing getTablet() below and not RemoteTablet. -- To view, visit http://gerrit.cloudera.org:8080/4836 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33984a437d8c8d07d5db4d16f8da723b3e904189 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
