Adar Dembo has posted comments on this change. Change subject: block_manager: consolidate data directory management ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4793/2/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: PS2, Line 310: do { : cur_idx = data_dirs_next_.Load(); : next_idx = (cur_idx + 1) % data_dirs_.size(); : } while (!data_dirs_next_.CompareAndSet(cur_idx, next_idx)); : : > Done On second thought, the next patch restores the full path checking, which could cause data_dirs_next_ to increase at a faster rate. So I'll leave it the way it is. -- To view, visit http://gerrit.cloudera.org:8080/4793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc9d8999117a6383e7487b6c5bf065f10247b1d7 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
