Dinesh Bhat has posted comments on this change. Change subject: block_manager: consolidate data directory management ......................................................................
Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4793/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1179: return s; > Correct, we'll let the destructor clean them up. We could explicitly close Nit: this kinda assumes that container Open() failure is always followed by a destructor call, which isn't a safe assumption IMHO. We can perhaps put a comment here to indicate that. -- To view, visit http://gerrit.cloudera.org:8080/4793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc9d8999117a6383e7487b6c5bf065f10247b1d7 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
