Adar Dembo has submitted this change and it was merged. Change subject: block_manager: consolidate data directory management ......................................................................
block_manager: consolidate data directory management This patch changes how data directories are handled. All of the duplicated logic between the two block managers is now encapsulated in two new classes (DataDir and DataDirManager), which can serve as the future foundation for a "disk grouping" feature. There should be little to no functional changes. Of note: - This refactoring makes the LBM check instance file integrity during Open() for the first time. Given that the remainder of the instance file handling was identical in both block managers, this should be harmless. - The LBM now opens per-directory instance files serially. This is a tiny amount of I/O next to container scanning, and while it can be done concurrently in the DataDirManager, I don't think it's worth the effort. Change-Id: Ifc9d8999117a6383e7487b6c5bf065f10247b1d7 Reviewed-on: http://gerrit.cloudera.org:8080/4793 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <[email protected]> Reviewed-by: Dinesh Bhat <[email protected]> --- M src/kudu/fs/CMakeLists.txt M src/kudu/fs/block_manager.cc M src/kudu/fs/block_manager.h A src/kudu/fs/data_dirs.cc A src/kudu/fs/data_dirs.h M src/kudu/fs/file_block_manager.cc M src/kudu/fs/file_block_manager.h M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h 9 files changed, 609 insertions(+), 470 deletions(-) Approvals: Dinesh Bhat: Looks good to me, but someone else must approve Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc9d8999117a6383e7487b6c5bf065f10247b1d7 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
