Dan Burkert has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4836/4/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: Line 163: return lastUuid; > It's not obvious to me why, care to explain? You worried we will always hit It's what the contract specifies, so either you need to change the javadoc or the method. I would prefer actually returning a random result, since it's more fool proof. Keep in mind this could (and probably does) return the same replica when called on different clients/JVMs. -- To view, visit http://gerrit.cloudera.org:8080/4836 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33984a437d8c8d07d5db4d16f8da723b3e904189 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
