Todd Lipcon has posted comments on this change. Change subject: rpc: support GSSAPI authentication ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4763/4/src/kudu/security/mini_kdc-test.cc File src/kudu/security/mini_kdc-test.cc: PS4, Line 24: #include "kudu/util/scoped_cleanup.h" > Is it really needed here? Done http://gerrit.cloudera.org:8080/#/c/4763/4/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: PS4, Line 107: const > nit: static const ? it seems to generate identical code whether it's static or not - either way, the string constant itself ends up being part of the const data section of the binary, and then we just directly use a pointer to that data in the setenv() calls. Since it's local scope, I think 'static' is more confusing than not. -- To view, visit http://gerrit.cloudera.org:8080/4763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1b93045acd428ef3437597059c5106b03e25d0 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
