Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4908
to review the following change.
Change subject: rpc: improve behavior when GSSAPI SASL plugin is missing
......................................................................
rpc: improve behavior when GSSAPI SASL plugin is missing
* If the client cannot enable the GSSAPI plugin, it now proceeds with a
connection anyway after logging a single VLOG(1) message. This allows
a client to connect to a non-Kerberos-enabled cluster without having
to install the GSSAPI plugin.
* If the server fails to enable the GSSAPI plugin for any reason, it now
sends back a FATAL_UNAUTHORIZED error so that the client can print
something reasonable. Unfortunately this one was tricky to test, so I
tested it manually by uninstalling the GSSAPI plugin on the server
side and connecting from another machine.
* If the client fails to negotiate a matching SASL mechanism, it
replaces the confusing "No worthy mechs" error message with something
that's more usable for the average user, suggesting to install the
GSSAPI plugin.
Change-Id: I49b991fd7088666a2b8daad18d70844ed8a5451f
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/negotiation.cc
M src/kudu/rpc/sasl_client.cc
M src/kudu/rpc/sasl_helper.cc
M src/kudu/rpc/sasl_rpc-test.cc
M src/kudu/rpc/sasl_server.cc
M src/kudu/rpc/sasl_server.h
7 files changed, 47 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/4908/1
--
To view, visit http://gerrit.cloudera.org:8080/4908
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49b991fd7088666a2b8daad18d70844ed8a5451f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
